huxihx commented on a change in pull request #9051:
URL: https://github.com/apache/kafka/pull/9051#discussion_r458613980
##########
File path:
core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala
##########
@@ -775,6 +775,24 @@ class DynamicBrokerReconfigurationTest extends
ZooKeeperTestHarness with SaslSet
verifyMarkPartitionsForTruncation()
}
+ @Test
+ def testDefaultValueRestoredAfterDeleteDynamicConfig(): Unit = {
+ val newProps = new Properties
+ newProps.put(KafkaConfig.LogRetentionTimeMillisProp, "100000")
+ newProps.put(KafkaConfig.LogFlushIntervalMsProp, "10000")
+ TestUtils.incrementalAlterConfigs(servers, adminClients.head, newProps,
perBrokerConfig = false).all.get
Review comment:
Thanks for the comments. We could add but not necessary since we care
about the fact that the value for broker-default level should be overwritten by
that for broker-level. Does it make sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
