mumrah commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r455094448
##########
File path:
clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java
##########
@@ -273,6 +99,28 @@ public boolean equals(Object o) {
}
}
+ private Map<TopicPartition, PartitionData>
toPartitionDataMap(List<FetchRequestData.FetchTopic> fetchableTopics) {
+ Map<TopicPartition, PartitionData> result = new LinkedHashMap<>();
+ fetchableTopics.forEach(fetchTopic ->
fetchTopic.partitions().forEach(fetchPartition -> {
+ Optional<Integer> leaderEpoch =
Optional.of(fetchPartition.currentLeaderEpoch())
+ .filter(epoch -> epoch !=
RecordBatch.NO_PARTITION_LEADER_EPOCH);
+ result.put(new TopicPartition(fetchTopic.topic(),
fetchPartition.partition()),
+ new PartitionData(fetchPartition.fetchOffset(),
fetchPartition.logStartOffset(),
+ fetchPartition.partitionMaxBytes(), leaderEpoch));
Review comment:
Yes, I think it's a good idea. However, it would expand the scope of
this change quite a bit. I'm working on some micro benchmarks now, and if we
don't have any apparent regressions then I'll save this for a follow-on PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
