cmccabe commented on a change in pull request #9012:
URL: https://github.com/apache/kafka/pull/9012#discussion_r453876571
##########
File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
##########
@@ -1199,7 +1199,7 @@ public ClientRequest newClientRequest(String nodeId,
AbstractRequest.Builder<?>
requestBuilder,
long createdTimeMs,
boolean expectResponse) {
- return newClientRequest(nodeId, requestBuilder, createdTimeMs,
expectResponse, defaultRequestTimeoutMs, null);
+ return newClientRequest(nodeId, requestBuilder, createdTimeMs,
expectResponse, defaultRequestTimeoutMs, null, "");
Review comment:
I think it would be best to use null here as the "not set" value. We
never clearly articulated that the empty string is not valid for principals.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
