ableegoldman commented on a change in pull request #8996:
URL: https://github.com/apache/kafka/pull/8996#discussion_r451922040
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java
##########
@@ -224,6 +224,9 @@ void initializeStoreOffsetsFromCheckpoint(final boolean
storeDirIsEmpty) {
for (final StateStoreMetadata store : stores.values()) {
if (store.changelogPartition == null) {
log.info("State store {} is not logged and hence would not
be restored", store.stateStore.name());
+ } else if (!store.stateStore.persistent()) {
+ log.info("Initializing to the starting offset for
changelog {} of in-memory state store {}",
+ store.changelogPartition,
store.stateStore.name());
Review comment:
> Don't we need to call store.setOffset(null) or this case?
Well, either it's a recycled task in which case no, we don't want to wipe
out the existing offset, or it's a new task in which case it's initialized to
`null` anyway.
I'm also not sure what you mean in the second comment. Did you maybe paste
the link to the wrong code? (just guessing since you linked to that same code
earlier in John's PR)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
