ableegoldman commented on a change in pull request #8994:
URL: https://github.com/apache/kafka/pull/8994#discussion_r451862588
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -766,6 +769,24 @@ void runOnce() {
return records;
}
+ private OffsetResetStrategy getResetStrategy(final TopicPartition
partition) {
+ if
(builder.earliestResetTopicsPattern().matcher(partition.topic()).matches()) {
+ return OffsetResetStrategy.EARLIEST;
+ } else if
(builder.latestResetTopicsPattern().matcher(partition.topic()).matches()) {
+ return OffsetResetStrategy.LATEST;
+ } else {
+ if (originalReset == null || (!originalReset.equals("earliest") &&
!originalReset.equals("latest"))) {
+ return OffsetResetStrategy.EARLIEST;
+ }
Review comment:
Does Streams override the client default..?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
