tombentley commented on pull request #8966:
URL: https://github.com/apache/kafka/pull/8966#issuecomment-655533627


   @omkreddy that is... an excellent question. 
   
   * In `HEAD` the only place it's set to non-null is in `RequestResponseTest`
   * In 9a4f00f78b (i.e. just before the change to use the generated message 
classes the situation is the same: Only non-null call sites are two tests in 
`RequestResponseTest`
   * ... and I chased it all the way back to 972b7545363ae, when the RPC was 
added, and it seems that this has always been the situation. One or two callers 
with non-null keys in `RequestResponseTest`. Thus supported (but without any 
test coverage) at the protocol level, but never exposed in the Java API. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to