junrao commented on a change in pull request #8981:
URL: https://github.com/apache/kafka/pull/8981#discussion_r451167086
##########
File path: tests/kafkatest/tests/core/transactions_test.py
##########
@@ -47,7 +47,10 @@ def __init__(self, test_context):
self.num_output_partitions = 3
self.num_seed_messages = 100000
self.transaction_size = 750
- self.transaction_timeout = 40000
+ # This is reducing the transaction cleanup interval.
+ # IN hard_bounce mode, transaction is broke ungracefully. Hence, it
produces unstable
Review comment:
broker => broken
##########
File path: tests/kafkatest/tests/core/transactions_test.py
##########
@@ -47,7 +47,10 @@ def __init__(self, test_context):
self.num_output_partitions = 3
self.num_seed_messages = 100000
self.transaction_size = 750
- self.transaction_timeout = 40000
+ # This is reducing the transaction cleanup interval.
+ # IN hard_bounce mode, transaction is broke ungracefully. Hence, it
produces unstable
+ # offsets which obstructs TransactionalMessageCopier from receiving
position of group.
+ self.transaction_timeout = 5000
Review comment:
Hmm, still not sure about this. In a hard bounce, the broker failure
will be detected after ZK session expiration, with a default of 18 sec. After
that, new leaders will be elected and the client should recover. So, the
transactional producer should be unblocked after 18 secs, even with a 40 sec
transaction_timeout?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
