abbccdda commented on a change in pull request #8989:
URL: https://github.com/apache/kafka/pull/8989#discussion_r450510257
##########
File path:
clients/src/test/java/org/apache/kafka/common/message/MessageTest.java
##########
@@ -218,6 +220,59 @@ public void testOffsetCommitDefaultGroupInstanceId()
throws Exception {
testAllMessageRoundTripsFromVersion((short) 7,
request.get().setGroupInstanceId(instanceId));
}
+ @Test
+ public void testDescribeGroupsRequestVersions() throws Exception {
+ testAllMessageRoundTrips(new DescribeGroupsRequestData()
+ .setGroups(Collections.singletonList("group"))
+ .setIncludeAuthorizedOperations(false));
+ }
+
+ @Test
+ public void testDescribeGroupsResponseVersions() throws Exception {
+ DescribedGroupMember baseMember = new DescribedGroupMember()
+ .setMemberId(memberId);
+
+ DescribedGroup baseGroup = new DescribedGroup()
+ .setGroupId("group")
+
.setGroupState("Stable").setErrorCode(Errors.NONE.code())
+
.setMembers(Collections.singletonList(baseMember))
+ .setProtocolType("consumer");
+ DescribeGroupsResponseData baseResponse = new
DescribeGroupsResponseData()
+
.setGroups(Collections.singletonList(baseGroup));
+ testAllMessageRoundTrips(baseResponse);
+
+ testAllMessageRoundTripsFromVersion((short) 1,
baseResponse.setThrottleTimeMs(10));
Review comment:
We would check for equality only with versions that already introduced
the new fields IMHO?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
