[GitHub] [kafka] chia7712 opened a new pull request #8974: KAFKA-10225 Increase default zk session timeout for system tests

[GitBox]

chia7712 opened a new pull request #8974:
URL: https://github.com/apache/kafka/pull/8974


   I'm digging in the flaky system tests and then I noticed there are many 
flaky caused by following check.
   ```python
           with node.account.monitor_log(KafkaService.STDOUT_STDERR_CAPTURE) as 
monitor:
               node.account.ssh(cmd)
               # Kafka 1.0.0 and higher don't have a space between "Kafka" and 
"Server"
               monitor.wait_until("Kafka\s*Server.*started", 
timeout_sec=timeout_sec, backoff_sec=.25,
                                  err_msg="Kafka server didn't finish startup 
in %d seconds" % timeout_sec)
   ```
   
   And the error message in broker log is shown below.
   ```
   kafka.zookeeper.ZooKeeperClientTimeoutException: Timed out waiting for 
connection while in state: CONNECTING
        at 
kafka.zookeeper.ZooKeeperClient.waitUntilConnected(ZooKeeperClient.scala:262)
        at kafka.zookeeper.ZooKeeperClient.<init>(ZooKeeperClient.scala:119)
        at kafka.zk.KafkaZkClient$.apply(KafkaZkClient.scala:1880)
        at kafka.server.KafkaServer.createZkClient$1(KafkaServer.scala:430)
        at kafka.server.KafkaServer.initZkClient(KafkaServer.scala:455)
        at kafka.server.KafkaServer.startup(KafkaServer.scala:227)
        at 
kafka.server.KafkaServerStartable.startup(KafkaServerStartable.scala:44)
        at kafka.Kafka$.main(Kafka.scala:82)
        at kafka.Kafka.main(Kafka.scala)
   ```
   
   I'm surprised the default timeout of zk connection in system test is only 2 
seconds as the default timeout in production is increased to 18s (see 
https://github.com/apache/kafka/commit/4bde9bb3ccaf5571be76cb96ea051dadaeeaf5c7)
   ```
   config_property.ZOOKEEPER_CONNECTION_TIMEOUT_MS: 2000
   ```
   
   
   
   
   issue: https://issues.apache.org/jira/browse/KAFKA-10225
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org