abbccdda commented on a change in pull request #8826:
URL: https://github.com/apache/kafka/pull/8826#discussion_r446543686



##########
File path: 
clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java
##########
@@ -159,24 +159,23 @@ private static ChannelBuilder create(SecurityProtocol 
securityProtocol,
     }
 
     // Visibility for testing
+    @SuppressWarnings("unchecked")
     protected static Map<String, Object> channelBuilderConfigs(final 
AbstractConfig config, final ListenerName listenerName) {
-        Map<String, ?> parsedConfigs;
+        Map<String, Object> parsedConfigs;

Review comment:
       I'm confused, why does convert the type of config will change the way we 
interpret the config value?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to