skaundinya15 commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r444631685
##########
File path:
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java
##########
@@ -84,6 +84,9 @@
public static final String RETRY_BACKOFF_MS_CONFIG = "retry.backoff.ms";
public static final String RETRY_BACKOFF_MS_DOC = "The amount of time to
wait before attempting to retry a failed request to a given topic partition.
This avoids repeatedly sending requests in a tight loop under some failure
scenarios.";
+ public static final String RETRY_BACKOFF_MAX_MS_CONFIG =
"retry.backoff.max.ms";
+ public static final String RETRY_BACKOFF_MAX_MS_DOC = "The maximum amount
of time in milliseconds to wait when retrying a request to the broker that has
repeatedly failed. If provided, the backoff per client will increase
exponentially for each failed request, up to this maximum. To prevent all
clients from being synchronized upon retry, a randomization factor of 0.2 will
be applied to the backoff, resulting in a random range between 20% below and
20% above the computed value. If retry.backoff.ms is set to be higher than
retry.backoff.max.ms, then retry.backoff.max.ms will be used as a constant
backoff from the beginning without any exponential increase";
Review comment:
Nit: Can we change the wording to the following?
```suggestion
public static final String RETRY_BACKOFF_MAX_MS_DOC = "The maximum
amount of time in milliseconds to wait when retrying a request to the broker
that has repeatedly failed. If provided, the backoff per client will increase
exponentially for each failed request, up to this maximum. To prevent all
clients from being synchronized upon retry, a randomized jitter with a factor
of 0.2 will be applied to the backoff, resulting in the backoff falling within
a range between 20% below and 20% above the computed value. If retry.backoff.ms
is set to be higher than retry.backoff.max.ms, then retry.backoff.max.ms will
be used as a constant backoff from the beginning without any exponential
increase";
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
