kowshik opened a new pull request #8857:
URL: https://github.com/apache/kafka/pull/8857


   The call to `ChangeNotificationProcessorThread.queue.take()` could throw an 
`InterruptedException`.  While the queue is empty and the thread is blocking on 
taking an item from the queue, a concurrent call to 
`FinalizedFeatureChangeListener.close()` could interrupt the thread and cause 
an `InterruptedException` to be raised from `queue.take()`. In such a case, it 
is safe to ignore the exception since the thread is being shutdown.
   
   Definitely ignoring the `InterruptedException` for the above reason was the 
intent of the code that used the `ignoring` clause for the same. But it seems 
unfortunately the `ignoring` clause does not ignore `InterruptedException`, so 
that doesn't work for us. To confirm this theory, I found the following code in 
`scala.util.control.Exception.scala`: 
https://github.com/scala/scala/blob/v2.12.0/src/library/scala/util/control/Exception.scala#L167-L176.
   
   The fix in this PR is to just not use the `ignoring` clause.
   
   **Test plan:**
   Ran the unit and integration tests and found that the test failures are gone 
now.
   I will wait for CI to pass before merging this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to