skaundinya15 commented on a change in pull request #8850:
URL: https://github.com/apache/kafka/pull/8850#discussion_r439156564
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -1784,8 +1785,24 @@ class Log(@volatile private var _dir: File,
private def deleteRetentionMsBreachedSegments(): Int = {
if (config.retentionMs < 0) return 0
val startMs = time.milliseconds
- deleteOldSegments((segment, _) => startMs - segment.largestTimestamp >
config.retentionMs,
- reason = s"retention time ${config.retentionMs}ms breach")
+
+ def shouldDelete(segment: LogSegment, nextSegmentOpt: Option[LogSegment])
= {
+ if (startMs - segment.largestTimestamp > config.retentionMs) {
+ segment.largestRecordTimestamp match {
+ case Some(ts) =>
+ info(s"Segment with base offset ${segment.baseOffset} will be
deleted due to" +
+ s" retentionMs breach. Largest record timestamp of segment is
$ts")
Review comment:
> Also, we seem to have lost mention o
I'll clarify the log message as you suggested. Could you explain what you
meant by the above?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
