showuon commented on pull request #8788:
URL: https://github.com/apache/kafka/pull/8788#issuecomment-640337271


   Thanks for the comment, @ableegoldman . Yes, I agree we should improve the 
stickiness verification, but I haven't got a better idea for that so far. I've 
created a ticket to track it:
   [KAFKA-10118](https://issues.apache.org/jira/browse/KAFKA-10118) - Improve 
stickiness verification for AbstractStickyAssignorTest
   
   For this PR, I also put the `partitionMovements` initialization back to 
`generalAssign` method sine we won't have NPE during testing anymore after this 
fix. I think we can firstly merge this PR, and then discuss the improvement in 
KAFKA-10118. 
   
   How do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to