mjsax commented on pull request #8825: URL: https://github.com/apache/kafka/pull/8825#issuecomment-640280224
Thanks for the PR. I looked into the code and the check to verify if names are overlapping is actually in `InternalTopologyBuilder` -- thus, the fix should there. In `InternalTopologyBuilderTest`, there is already `shouldNotAllowToAddStoresWithSameName` - - but it only covers the case for two "regular" store. The bug is really for adding a regular store and global store with the same name. Seems, we also lack a test for adding two global stores with the same names. Also note, that for adding a regular store first, and afterwards a global store, there seems to be not bug atm -- only if the global store is added first and the regular store second the issue is there. Thus, we should test both combinations. Does this make sense? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
