hachikuji commented on a change in pull request #8816:
URL: https://github.com/apache/kafka/pull/8816#discussion_r436191206



##########
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##########
@@ -1186,6 +1185,9 @@ class GroupCoordinator(val brokerId: Int,
           for (member <- group.allMemberMetadata) {
             val joinResult = JoinGroupResult(
               members = if (group.isLeader(member.memberId)) {
+                info(s"Group ${group.groupId} replies the leader with " +

Review comment:
       Do we need to print this for every member? That is O(n^2). Keep in mind 
that groups in the thousands are not unheard of. I think it would be better if 
we just ensured that we log the id of every member entering and leaving the 
group.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to