mjsax commented on pull request #8776: URL: https://github.com/apache/kafka/pull/8776#issuecomment-639154057
> I'm mildly concerned that we're using the state to implement idempotence of processing steps, but the states aren't 1:1 with the steps. For example, when we go from RUNNING to CLOSED, we transition through both prepareClose() and close(). But there's no CLOSE_PREPARED state, so there's no way to really differentiate that specifically prepareClose() has completed before, but not close(). Correct. Note that there will be more follow up PR, that will remove, eg, `prepareClose()` so this will be addressed soon. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
