abbccdda commented on a change in pull request #8486:
URL: https://github.com/apache/kafka/pull/8486#discussion_r434289002
##########
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java
##########
@@ -3831,7 +3845,12 @@ private void
testOffsetValidationWithGivenEpochOffset(final EpochEndOffset epoch
consumerClient.poll(time.timer(Duration.ZERO));
assertEquals(0, subscriptions.position(tp0).offset);
- assertFalse(subscriptions.awaitingValidation(tp0));
+
+ if (offsetResetStrategy == OffsetResetStrategy.NONE) {
+ assertTrue(subscriptions.awaitingValidation(tp0));
+ } else {
+ assertFalse(subscriptions.awaitingValidation(tp0));
Review comment:
As discussed offline, we plan to address this gap in a separate PR for
https://issues.apache.org/jira/browse/KAFKA-10087 as some other bug to fix for
log truncation exception propagation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
