ableegoldman commented on pull request #8668: URL: https://github.com/apache/kafka/pull/8668#issuecomment-637154355
@twmb yeah, I should point out in the ticket that this approach drops the optimization giving preference to older-generation owners of a partition. I actually don't think it would be particularly difficult to incorporate into this new algorithm, but my take was that it still adds more complexity than any benefit it provides. We actually dropped this implicitly in the cooperative assignor, since a member with an older generation will have to give up all of its owned partitions before rejoining the group anyway. It was nice to be able to build up the `partitionsTransferringOwnership` with the additional context we have while crafting the assignment, but to be fair it may be somewhat of an over-optimization at this point. The `adjustAssignment` loop that was building it up from scratch still performed fine up to ~5-10 million partitions. But I figure, better to optimize now and not have to worry about it later 🙂 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
