[ 
https://issues.apache.org/jira/browse/KAFKA-10068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119922#comment-17119922
 ] 

John Roesler commented on KAFKA-10068:
--------------------------------------

Thanks Matthias,

I wasn't talking about computing a deadline, but benchmarking the existing 
implementation. I guess we could pick 50% of the _default_ max poll interval, 
which is 5 minutes, but I'd honestly be disappointed and a little shocked if 
the assign() function blocked for 2.5 minutes every time it needs to make an 
assignment.

The choice of 30s was arbitrary. It's the same bound we put on the consumer 
sticky task assignor in 
https://github.com/apache/kafka/pull/8668/files#diff-8dbc18b5be02d6b1bccda4bc3babdabbR425

> Verify HighAvailabilityTaskAssignor performance with large clusters and 
> topologies
> ----------------------------------------------------------------------------------
>
>                 Key: KAFKA-10068
>                 URL: https://issues.apache.org/jira/browse/KAFKA-10068
>             Project: Kafka
>          Issue Type: Task
>          Components: streams
>    Affects Versions: 2.6.0
>            Reporter: John Roesler
>            Priority: Blocker
>
> While reviewing [https://github.com/apache/kafka/pull/8668/files,] I realized 
> that we should have a similar test to make sure that the new task assignor 
> completes well within the default assignment deadline. 30 seconds is a good 
> upper bound.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to