[GitHub] [kafka] vinothchandar commented on a change in pull request #8737: KAFKA-9945: TopicCommand should support --if-exists and --if-not-exists when --bootstrap-server is used

[GitBox]

vinothchandar commented on a change in pull request #8737:
URL: https://github.com/apache/kafka/pull/8737#discussion_r432566976



##########
File path: core/src/main/scala/kafka/admin/TopicCommand.scala
##########
@@ -736,8 +743,8 @@ object TopicCommand extends Logging {
         allTopicLevelOpts -- Set(describeOpt) ++ allReplicationReportOpts - 
reportUnavailablePartitionsOpt + topicsWithOverridesOpt)
       CommandLineUtils.checkInvalidArgs(parser, options, 
topicsWithOverridesOpt,
         allTopicLevelOpts -- Set(describeOpt) ++ allReplicationReportOpts)
-      CommandLineUtils.checkInvalidArgs(parser, options, ifExistsOpt, 
allTopicLevelOpts -- Set(alterOpt, deleteOpt, describeOpt) ++ 
Set(bootstrapServerOpt))
-      CommandLineUtils.checkInvalidArgs(parser, options, ifNotExistsOpt, 
allTopicLevelOpts -- Set(createOpt) ++ Set(bootstrapServerOpt))

Review comment:
       I think you meant a test.. if so, the tests I added already use 
--bootstrap-server with these options.. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org