srpanwar-confluent commented on a change in pull request #8723:
URL: https://github.com/apache/kafka/pull/8723#discussion_r432370145
##########
File path: core/src/main/scala/kafka/server/AdminManager.scala
##########
@@ -658,6 +658,26 @@ class AdminManager(val config: KafkaConfig,
DynamicBrokerConfig.brokerConfigSynonyms(name, matchListenerOverride =
true)
}
+ private def brokerDocumentation(name: String): String = {
+ config.documentationOf(name)
+ }
+
+ private def configResponseType(configType: Option[ConfigDef.Type]):
DescribeConfigsResponse.ConfigType = {
+ if (configType.isEmpty)
+ DescribeConfigsResponse.ConfigType.UNKNOWN
+ else configType.get match {
+ case ConfigDef.Type.BOOLEAN => DescribeConfigsResponse.ConfigType.BOOLEAN
+ case ConfigDef.Type.STRING => DescribeConfigsResponse.ConfigType.STRING
+ case ConfigDef.Type.INT => DescribeConfigsResponse.ConfigType.INT
+ case ConfigDef.Type.SHORT => DescribeConfigsResponse.ConfigType.SHORT
+ case ConfigDef.Type.LONG => DescribeConfigsResponse.ConfigType.LONG
+ case ConfigDef.Type.DOUBLE => DescribeConfigsResponse.ConfigType.DOUBLE
+ case ConfigDef.Type.LIST => DescribeConfigsResponse.ConfigType.LIST
+ case ConfigDef.Type.CLASS => DescribeConfigsResponse.ConfigType.CLASS
+ case ConfigDef.Type.PASSWORD =>
DescribeConfigsResponse.ConfigType.PASSWORD
Review comment:
Return UNKNOWN to prevent older clients from breaking
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
