[GitHub] [kafka] vvcephei commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

[GitBox]

vvcephei commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r432143143



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java
##########
@@ -79,25 +88,27 @@
 
     private static final String APPID = "restore-test";
 
-    @ClassRule
-    public static final EmbeddedKafkaCluster CLUSTER =
-            new EmbeddedKafkaCluster(NUM_BROKERS);
+    public final EmbeddedKafkaCluster cluster = new 
EmbeddedKafkaCluster(NUM_BROKERS);

Review comment:
       I see. Maybe making it a Rule instead of a ClassRule is the solution 
you're looking for?
   
   But yes, there's a middle ground, which is to use uniquely named resources 
for each test, for which we have 
`org.apache.kafka.streams.integration.utils.IntegrationTestUtils#safeUniqueTestName`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org