abbccdda commented on a change in pull request #8677:
URL: https://github.com/apache/kafka/pull/8677#discussion_r426380898



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java
##########
@@ -171,7 +173,7 @@ public InternalTopicManager(final Admin adminClient, final 
StreamsConfig streams
                 "This can happen if the Kafka cluster is temporary not 
available. " +
                 "You can increase admin client config `retries` to be 
resilient against this error.", retries);
             log.error(timeoutAndRetryError);
-            throw new StreamsException(timeoutAndRetryError);
+            throw new TaskMigratedException("Time out for creating internal 
topics", new TimeoutException(timeoutAndRetryError));

Review comment:
       I took a look at the codepath, and have some doubts on whether we could 
be able to complete the assignment because if the internal topic creations 
failed, we don't have valid sub partitions to be assigned correct?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to