pgwhalen commented on pull request #6824: URL: https://github.com/apache/kafka/pull/6824#issuecomment-629933557
@mjsax Thanks for the initial review! I believe I have addressed all comments (some of which I had questions about) except for comments on documentation in `processor-api.html` and `KStream.java` specifically. For the latter I just abandoned my changes in the merge from `trunk` for now; I will re-apply them within the next couple of days with the extra variants created since this PR was initially created (and the changes you've suggested). Just didn't have time to get to them tonight. I asked this on the dev mailing list a while ago but didn't get a great answer - is there some sort of tooling I can use to edit the HTML docs like `processor-api.html`? I really don't understand what all the HTML classes are (e.g. `c1`, `o`, `na`, `s` etc.), and can't figure out how to get rendered code formatted the way I want without extraordinarily tedious trial and error; that's one of the reasons the rendered code is formatted poorly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
