bdbyrne commented on a change in pull request #8675:
URL: https://github.com/apache/kafka/pull/8675#discussion_r425835352



##########
File path: core/src/main/scala/kafka/admin/ConfigCommand.scala
##########
@@ -424,7 +425,7 @@ object ConfigCommand extends Config {
         case ConfigType.Topic =>
           adminClient.listTopics(new 
ListTopicsOptions().listInternal(true)).names().get().asScala.toSeq
         case ConfigType.Broker | BrokerLoggerConfigType =>
-          adminClient.describeCluster(new 
DescribeClusterOptions()).nodes().get().asScala.map(_.idString).toSeq :+ 
ConfigEntityName.Default
+          adminClient.describeCluster(new 
DescribeClusterOptions()).nodes().get().asScala.map(_.idString).toSeq :+ 
BrokerDefaultEntityName

Review comment:
       Please substitute `""` for `BrokerDefaultEntityName` in the `match` 
below, as well as in `getResourceConfig`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to