mjsax commented on a change in pull request #8114:
URL: https://github.com/apache/kafka/pull/8114#discussion_r421957152
##########
File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java
##########
@@ -397,7 +397,7 @@
* {@link KafkaStreams#store(StoreQueryParameters)
KafkaStreams#store(...)}:
* <pre>{@code
* KafkaStreams streams = ...
- * ReadOnlyKeyValueStore<K,ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedKeyValueStore());
+ * ReadOnlyKeyValueStore<K, ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedKeyValueStore());
Review comment:
```suggestion
* ReadOnlyKeyValueStore<K, ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<V>>timestampedKeyValueStore());
```
##########
File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java
##########
@@ -212,7 +212,7 @@
* {@link KafkaStreams#store(StoreQueryParameters)
KafkaStreams#store(...)}:
* <pre>{@code
* KafkaStreams streams = ...
- * ReadOnlyKeyValueStore<K,ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedKeyValueStore());
+ * ReadOnlyKeyValueStore<K, ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedKeyValueStore());
Review comment:
```suggestion
* ReadOnlyKeyValueStore<K, ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<V>>timestampedKeyValueStore());
```
##########
File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java
##########
@@ -439,7 +439,7 @@
* {@link KafkaStreams#store(StoreQueryParameters)
KafkaStreams#store(...)}:
* <pre>{@code
* KafkaStreams streams = ...
- * ReadOnlyKeyValueStore<K,ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedKeyValueStore());
+ * ReadOnlyKeyValueStore<K, ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedKeyValueStore());
Review comment:
```suggestion
* ReadOnlyKeyValueStore<K, ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<V>>timestampedKeyValueStore());
```
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/KGroupedStream.java
##########
@@ -116,7 +116,7 @@
* <pre>{@code
* KafkaStreams streams = ... // counting words
* String queryableStoreName = "storeName"; // the store name should be
the name of the store as defined by the Materialized instance
- * ReadOnlyKeyValueStore<K,ValueAndTimestamp<Long>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<Long>> timestampedKeyValueStore());
+ * ReadOnlyKeyValueStore<K, ValueAndTimestamp<Long>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<Long>> timestampedKeyValueStore());
Review comment:
```suggestion
* ReadOnlyKeyValueStore<K, ValueAndTimestamp<Long>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<Long>>timestampedKeyValueStore());
```
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/KGroupedStream.java
##########
@@ -161,7 +161,7 @@
* <pre>{@code
* KafkaStreams streams = ... // counting words
* String queryableStoreName = "storeName"; // the store name should be
the name of the store as defined by the Materialized instance
- * ReadOnlyKeyValueStore<K,ValueAndTimestamp<Long>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<Long>> timestampedKeyValueStore());
+ * ReadOnlyKeyValueStore<K, ValueAndTimestamp<Long>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<Long>> timestampedKeyValueStore());
Review comment:
```suggestion
* ReadOnlyKeyValueStore<K, ValueAndTimestamp<Long>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<Long>>timestampedKeyValueStore());
```
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/KGroupedStream.java
##########
@@ -326,7 +326,7 @@
* <pre>{@code
* KafkaStreams streams = ... // compute sum
* String queryableStoreName = "storeName" // the store name should be the
name of the store as defined by the Materialized instance
- * ReadOnlyKeyValueStore<K,ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedKeyValueStore());
+ * ReadOnlyKeyValueStore<K, ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedKeyValueStore());
Review comment:
```suggestion
* ReadOnlyKeyValueStore<K, ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<V>>timestampedKeyValueStore());
```
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/KGroupedStream.java
##########
@@ -263,7 +263,7 @@
* <pre>{@code
* KafkaStreams streams = ... // compute sum
* String queryableStoreName = "storeName" // the store name should be the
name of the store as defined by the Materialized instance
- * ReadOnlyKeyValueStore<K,ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedKeyValueStore());
+ * ReadOnlyKeyValueStore<K, ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedKeyValueStore());
Review comment:
```suggestion
* ReadOnlyKeyValueStore<K, ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<V>>timestampedKeyValueStore());
```
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/KGroupedStream.java
##########
@@ -429,7 +429,7 @@
* <pre>{@code
* KafkaStreams streams = ... // some aggregation on value type double
* String queryableStoreName = "storeName" // the store name should be the
name of the store as defined by the Materialized instance
- * ReadOnlyKeyValueStore<K,ValueAndTimestamp<VR>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<VR>> timestampedKeyValueStore());
+ * ReadOnlyKeyValueStore<K, ValueAndTimestamp<VR>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<VR>> timestampedKeyValueStore());
Review comment:
```suggestion
* ReadOnlyKeyValueStore<K, ValueAndTimestamp<VR>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<VR>>timestampedKeyValueStore());
```
##########
File path: streams/src/main/java/org/apache/kafka/streams/kstream/KTable.java
##########
@@ -134,7 +134,7 @@
* {@link KafkaStreams#store(StoreQueryParameters)
KafkaStreams#store(...)}:
* <pre>{@code
* KafkaStreams streams = ... // filtering words
- * ReadOnlyKeyValueStore<K,ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedKeyValueStore());
+ * ReadOnlyKeyValueStore<K, ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedKeyValueStore());
Review comment:
```suggestion
* ReadOnlyKeyValueStore<K, ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<V>>timestampedKeyValueStore());
```
##########
File path: streams/src/main/java/org/apache/kafka/streams/kstream/KTable.java
##########
@@ -173,7 +173,7 @@
* {@link KafkaStreams#store(StoreQueryParameters)
KafkaStreams#store(...)}:
* <pre>{@code
* KafkaStreams streams = ... // filtering words
- * ReadOnlyKeyValueStore<K,ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedKeyValueStore());
+ * ReadOnlyKeyValueStore<K, ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedKeyValueStore());
Review comment:
```suggestion
* ReadOnlyKeyValueStore<K, ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<V>>timestampedKeyValueStore());
```
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindowedKStream.java
##########
@@ -386,7 +386,7 @@
* <pre>{@code
* KafkaStreams streams = ... // counting words
* Store queryableStoreName = ... // the queryableStoreName should be the
name of the store as defined by the Materialized instance
- * ReadOnlyWindowStore<K,ValueAndTimestamp<VR>> localWindowStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<VR>> timestampedWindowStore());
+ * ReadOnlyWindowStore<K, ValueAndTimestamp<VR>> localWindowStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<VR>> timestampedWindowStore());
Review comment:
```suggestion
* ReadOnlyWindowStore<K, ValueAndTimestamp<VR>> localWindowStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<VR>>timestampedWindowStore());
```
##########
File path: streams/src/main/java/org/apache/kafka/streams/kstream/KTable.java
##########
@@ -297,7 +297,7 @@
* {@link KafkaStreams#store(StoreQueryParameters)
KafkaStreams#store(...)}:
* <pre>{@code
* KafkaStreams streams = ... // filtering words
- * ReadOnlyKeyValueStore<K,ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedKeyValueStore());
+ * ReadOnlyKeyValueStore<K, ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedKeyValueStore());
Review comment:
```suggestion
* ReadOnlyKeyValueStore<K, ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<V>>timestampedKeyValueStore());
```
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindowedCogroupedKStream.java
##########
@@ -160,7 +160,7 @@
* <pre>{@code
* KafkaStreams streams = ... // counting words
* Store queryableStoreName = ... // the queryableStoreName should be the
name of the store as defined by the Materialized instance
- * ReadOnlyWindowStore<K,ValueAndTimestamp<V>> localWindowStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedWindowStore());
+ * ReadOnlyWindowStore<K, ValueAndTimestamp<V>> localWindowStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedWindowStore());
Review comment:
```suggestion
* ReadOnlyWindowStore<K, ValueAndTimestamp<V>> localWindowStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<V>>timestampedWindowStore());
```
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindowedKStream.java
##########
@@ -130,7 +130,7 @@
* <pre>{@code
* KafkaStreams streams = ... // counting words
* Store queryableStoreName = ... // the queryableStoreName should be the
name of the store as defined by the Materialized instance
- * ReadOnlyWindowStore<K,ValueAndTimestamp<Long>> localWindowStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<Long>> timestampedWindowStore());
+ * ReadOnlyWindowStore<K, ValueAndTimestamp<Long>> localWindowStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<Long>> timestampedWindowStore());
Review comment:
```suggestion
* ReadOnlyWindowStore<K, ValueAndTimestamp<Long>> localWindowStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<Long>>timestampedWindowStore());
```
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindowedKStream.java
##########
@@ -178,7 +178,7 @@
* <pre>{@code
* KafkaStreams streams = ... // counting words
* Store queryableStoreName = ... // the queryableStoreName should be the
name of the store as defined by the Materialized instance
- * ReadOnlyWindowStore<K,ValueAndTimestamp<Long>> localWindowStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<Long>> timestampedWindowStore());
+ * ReadOnlyWindowStore<K, ValueAndTimestamp<Long>> localWindowStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<Long>> timestampedWindowStore());
Review comment:
```suggestion
* ReadOnlyWindowStore<K, ValueAndTimestamp<Long>> localWindowStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<Long>>timestampedWindowStore());
```
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/KGroupedStream.java
##########
@@ -487,7 +487,7 @@
* <pre>{@code
* KafkaStreams streams = ... // some aggregation on value type double
* String queryableStoreName = "storeName" // the store name should be the
name of the store as defined by the Materialized instance
- * ReadOnlyKeyValueStore<K,ValueAndTimestamp<VR>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<String,
ValueAndTimestamp<VR>> timestampedKeyValueStore());
+ * ReadOnlyKeyValueStore<K, ValueAndTimestamp<VR>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<String,
ValueAndTimestamp<VR>> timestampedKeyValueStore());
Review comment:
```suggestion
* ReadOnlyKeyValueStore<K, ValueAndTimestamp<VR>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<String,
ValueAndTimestamp<VR>>timestampedKeyValueStore());
```
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindowedKStream.java
##########
@@ -326,7 +326,7 @@
* <pre>{@code
* KafkaStreams streams = ... // counting words
* Store queryableStoreName = ... // the queryableStoreName should be the
name of the store as defined by the Materialized instance
- * ReadOnlyWindowStore<K,ValueAndTimestamp<VR>> localWindowStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<VR>> timestampedWindowStore());
+ * ReadOnlyWindowStore<K, ValueAndTimestamp<VR>> localWindowStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<VR>> timestampedWindowStore());
Review comment:
```suggestion
* ReadOnlyWindowStore<K, ValueAndTimestamp<VR>> localWindowStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<VR>>timestampedWindowStore());
```
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindowedCogroupedKStream.java
##########
@@ -216,7 +216,7 @@
* <pre>{@code
* KafkaStreams streams = ... // counting words
* Store queryableStoreName = ... // the queryableStoreName should be the
name of the store as defined by the Materialized instance
- * ReadOnlyWindowStore<K,ValueAndTimestamp<V>> localWindowStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedWindowStore());
+ * ReadOnlyWindowStore<K, ValueAndTimestamp<V>> localWindowStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedWindowStore());
Review comment:
```suggestion
* ReadOnlyWindowStore<K, ValueAndTimestamp<V>> localWindowStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<V>>timestampedWindowStore());
```
##########
File path: streams/src/main/java/org/apache/kafka/streams/kstream/KTable.java
##########
@@ -259,7 +259,7 @@
* {@link KafkaStreams#store(StoreQueryParameters)
KafkaStreams#store(...)}:
* <pre>{@code
* KafkaStreams streams = ... // filtering words
- * ReadOnlyKeyValueStore<K,ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedKeyValueStore());
+ * ReadOnlyKeyValueStore<K, ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedKeyValueStore());
Review comment:
```suggestion
* ReadOnlyKeyValueStore<K, ValueAndTimestamp<V>> localStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<V>>timestampedKeyValueStore());
```
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindowedKStream.java
##########
@@ -605,7 +605,7 @@
* <pre>{@code
* KafkaStreams streams = ... // counting words
* Store queryableStoreName = ... // the queryableStoreName should be the
name of the store as defined by the Materialized instance
- * ReadOnlyWindowStore<K,ValueAndTimestamp<V>> localWindowStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedWindowStore());
+ * ReadOnlyWindowStore<K, ValueAndTimestamp<V>> localWindowStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedWindowStore());
Review comment:
```suggestion
* ReadOnlyWindowStore<K, ValueAndTimestamp<V>> localWindowStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<V>>timestampedWindowStore());
```
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindowedKStream.java
##########
@@ -543,7 +543,7 @@
* <pre>{@code
* KafkaStreams streams = ... // counting words
* Store queryableStoreName = ... // the queryableStoreName should be the
name of the store as defined by the Materialized instance
- * ReadOnlyWindowStore<K,ValueAndTimestamp<V>> localWindowStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedWindowStore());
+ * ReadOnlyWindowStore<K, ValueAndTimestamp<V>> localWindowStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>
timestampedWindowStore());
Review comment:
```suggestion
* ReadOnlyWindowStore<K, ValueAndTimestamp<V>> localWindowStore =
streams.store(queryableStoreName, QueryableStoreTypes.<K,
ValueAndTimestamp<V>>timestampedWindowStore());
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
