ijuma commented on a change in pull request #8602:
URL: https://github.com/apache/kafka/pull/8602#discussion_r420942672
##########
File path:
core/src/test/scala/integration/kafka/api/TransactionsBounceTest.scala
##########
@@ -156,17 +152,26 @@ class TransactionsBounceTest extends
KafkaServerTestHarness {
val expectedValues = (0 until numInputRecords).toSet
assertEquals(s"Missing messages: ${expectedValues -- recordSet}",
expectedValues, recordSet)
+ }
- verifyingConsumer.close()
+ private def createTransactionalProducer(transactionalId: String) = {
+ val props = new Properties()
+ props.put(ProducerConfig.ACKS_CONFIG, "all")
+ props.put(ProducerConfig.BATCH_SIZE_CONFIG, "512")
+ props.put(ProducerConfig.TRANSACTIONAL_ID_CONFIG, transactionalId)
+ props.put(ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG, "true")
+ createProducer(configOverrides = props)
Review comment:
I was checking the difference between what we do now and before and
noticed that we have this line in the helper method we were using previously:
> props.put(ProducerConfig.REQUEST_TIMEOUT_MS_CONFIG,
deliveryTimeoutMs.toString)
That seems a bit questionable. Should we remove it from that method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
