[
https://issues.apache.org/jira/browse/KAFKA-9845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17079495#comment-17079495
]
ASF GitHub Bot commented on KAFKA-9845:
---------------------------------------
C0urante commented on pull request #8455: KAFKA-9845: Fix plugin.path when
config provider is used
URL: https://github.com/apache/kafka/pull/8455
[Jira](https://issues.apache.org/jira/browse/KAFKA-9845)
These changes cause the transformed worker configuration to be passed to the
`Plugins` instance which performs plugin path scanning, instead of the raw
(pre-transform) worker configuration.
This has the added benefit that worker configuration validation now takes
place _before_ plugin path scanning, which in some environments can take a
while.
No tests are added as the chance of regression is extremely small and the
accuracy of the fix can be easily verified by reading the code changes and/or
through local testing with a file-based config provider.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> plugin.path property does not work with config provider
> -------------------------------------------------------
>
> Key: KAFKA-9845
> URL: https://issues.apache.org/jira/browse/KAFKA-9845
> Project: Kafka
> Issue Type: Bug
> Components: KafkaConnect
> Affects Versions: 2.3.0, 2.4.0, 2.3.1, 2.5.0, 2.4.1
> Reporter: Chris Egerton
> Assignee: Chris Egerton
> Priority: Major
>
> The config provider mechanism doesn't work if used for the {{plugin.path}}
> property of a standalone or distributed Connect worker. This is because the
> {{Plugins}} instance which performs plugin path scanning is created using the
> raw worker config, pre-transformation (see
> [ConnectStandalone|https://github.com/apache/kafka/blob/371ad143a6bb973927c89c0788d048a17ebac91a/connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectStandalone.java#L79]
> and
> [ConnectDistributed|https://github.com/apache/kafka/blob/371ad143a6bb973927c89c0788d048a17ebac91a/connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java#L91]).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
