[
https://issues.apache.org/jira/browse/KAFKA-8820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053714#comment-17053714
]
ASF GitHub Bot commented on KAFKA-8820:
---------------------------------------
cmccabe commented on pull request #8244: KAFKA-8820:
kafka-reassign-partitions.sh should support the KIP-455 API
URL: https://github.com/apache/kafka/pull/8244
Rewrite ReassignPartitionsCommand to use the KIP-455 API when possible,
rather
than direct communication with ZooKeeper. Direct ZK access is still
supported,
but deprecated, as described in KIP-455.
As specified in KIP-455, the tool has several new flags. --cancel stops
an assignment which is in progress. --preserve-throttle causes the
--verify and --cancel commands to leave the throttles alone.
--additional allows users to execute another partition assignment even
if there is already one in progress. Finally, --show displays all of
the current partition reassignments.
Reorganize the reassignment code and tests somewhat to rely more on unit
testing using the MockAdminClient and less on integration testing. Each
integration test where we bring up a cluster seems to take about 5 seconds,
so
it's good when we can get similar coverage from unit tests. To enable this,
MockAdminClient now supports incrementalAlterConfigs, alterReplicaLogDirs,
describeReplicaLogDirs, and some other APIs. MockAdminClient is also now
thread-safe, to match the real AdminClient implementation.
In DeleteTopicTest, use the KIP-455 API rather than invoking the reassignment
command.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> kafka-reassign-partitions.sh should support the KIP-455 API
> -----------------------------------------------------------
>
> Key: KAFKA-8820
> URL: https://issues.apache.org/jira/browse/KAFKA-8820
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Gwen Shapira
> Assignee: Colin McCabe
> Priority: Major
>
> KIP-455 and KAFKA-8345 add a protocol and AdminAPI that will be used for
> replica reassignments. We need to update the reassignment tool to use this
> new API rather than work with ZK directly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
