[
https://issues.apache.org/jira/browse/KAFKA-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032766#comment-17032766
]
ASF GitHub Bot commented on KAFKA-9254:
---------------------------------------
soondenana commented on pull request #8067: KAFKA-9254; Overridden topic
configs are reset after dynamic default change (#7870)
URL: https://github.com/apache/kafka/pull/8067
Currently, when a dynamic change is made to the broker-level default log
configuration, existing log configs will be recreated with an empty overridden
configs. In such case, when updating dynamic broker configs a second round, the
topic-level configs are lost. This can cause unexpected data loss, for example,
if the cleanup policy changes from "compact" to "delete."
Reviewers: Rajini Sivaram <rajinisiva...@googlemail.com>, Jason Gustafson
<ja...@confluent.io>
(cherry picked from commit 0e7f867041959c5d77727c7f5ce32d363fa09fc2)
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Updating Kafka Broker configuration dynamically twice reverts log
> configuration to default
> ------------------------------------------------------------------------------------------
>
> Key: KAFKA-9254
> URL: https://issues.apache.org/jira/browse/KAFKA-9254
> Project: Kafka
> Issue Type: Bug
> Components: config, log, replication
> Affects Versions: 2.0.1, 2.1.1, 2.2.2, 2.4.0, 2.3.1
> Reporter: fenghong
> Assignee: huxihx
> Priority: Critical
> Fix For: 2.0.2, 2.1.2, 2.2.3, 2.3.2, 2.4.1
>
>
> We are engineers at Huobi and now encounter Kafka BUG
> Modifying DynamicBrokerConfig more than 2 times will invalidate the topic
> level unrelated configuration
> The bug reproduction method as follows：
> # Set Kafka Broker config server.properties min.insync.replicas=3
> # Create topic test-1 and set topic‘s level config min.insync.replicas=2
> # Dynamically modify the configuration twice as shown below
> {code:java}
> bin/kafka-configs.sh --bootstrap-server xxx:9092 --entity-type brokers
> --entity-default --alter --add-config log.message.timestamp.type=LogAppendTime
> bin/kafka-configs.sh --bootstrap-server xxx:9092 --entity-type brokers
> --entity-default --alter --add-config log.retention.ms=604800000
> {code}
> # stop a Kafka Server and found the Exception as shown below
> org.apache.kafka.common.errors.NotEnoughReplicasException: Number of insync
> replicas for partition test-1-0 is [2], below required minimum [3]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
