[ https://issues.apache.org/jira/browse/KAFKA-9430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031166#comment-17031166 ]
Vinoth Chandar commented on KAFKA-9430: --------------------------------------- [~guozhang] IIUC that change you point out, has simplified how we obtain the current position.. but we are still use end offsets of the actual source topic right? [https://github.com/guozhangwang/kafka/blob/k9113-base/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java#L1243] > Tighten up lag estimates when source topic optimization is on > -------------------------------------------------------------- > > Key: KAFKA-9430 > URL: https://issues.apache.org/jira/browse/KAFKA-9430 > Project: Kafka > Issue Type: Improvement > Components: streams > Affects Versions: 2.5.0 > Reporter: Vinoth Chandar > Assignee: Vinoth Chandar > Priority: Blocker > > Right now, we use _endOffsets_ of the source topic for the computation. For > "optimized" changelogs, this will be wrong, strictly speaking, but it's an > over-estimate (which seems better than an under-estimate), and it's also > still an apples-to-apples comparison, since all replicas would use the same > upper bound to compute their lags, so the "pick the freshest" replica is > still going to pick the right one. > The current implementation is technically correct, within the documented > behavior that the result is an "estimate", but I marked it as a blocker to be > sure that we revisit it after ongoing work to refactor the task management in > Streams is complete. If it becomes straightforward to tighten up the > estimate, we should go ahead and do it. Otherwise, we can downgrade the > priority of the ticket. -- This message was sent by Atlassian Jira (v8.3.4#803005)