[
https://issues.apache.org/jira/browse/KAFKA-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031074#comment-17031074
]
ASF GitHub Bot commented on KAFKA-9509:
---------------------------------------
skaundinya15 commented on pull request #8048: KAFKA-9509: Fixing flakiness of
MirrorConnectorsIntegrationTest.testReplication
URL: https://github.com/apache/kafka/pull/8048
JIRA: https://issues.apache.org/jira/browse/KAFKA-9509
As the JIRA indicates,
`org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest.testReplication`
has shown to be an increasingly flaky test recently. This PR aims to make this
test more deterministic. Specifically, the flakiness was due to a timing issue
between the tasks not starting up in time for the test to start running. This
PR remediates that by introducing a status check after every connector is
started up. These status checks include that the connector is found on the
connect cluster as well as there are tasks created and up and running for that
connector. These checks are introduced before the test starts running so that
there is a confidence that the connectors and tasks are started up correctly
before the test runs.
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behavior change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix flaky test MirrorConnectorsIntegrationTest.testReplication
> --------------------------------------------------------------
>
> Key: KAFKA-9509
> URL: https://issues.apache.org/jira/browse/KAFKA-9509
> Project: Kafka
> Issue Type: Test
> Components: mirrormaker
> Affects Versions: 2.4.0, 2.4.1, 2.5.0
> Reporter: Sanjana Kaundinya
> Assignee: Sanjana Kaundinya
> Priority: Major
>
> The test `MirrorConnectorsIntegrationTest.testReplication` is a flaky test
> for MirrorMaker 2.0. Its flakiness lies in the timing of when the connectors
> and tasks are started up. The fix for this would make it such that when the
> connectors are started up, to wait until the REST endpoint returns a positive
> number of tasks to be confident that we can start testing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
