[ 
https://issues.apache.org/jira/browse/KAFKA-9330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17010003#comment-17010003
 ] 

ASF GitHub Bot commented on KAFKA-9330:
---------------------------------------

hachikuji commented on pull request #7866: KAFKA-9330: Skip `join` when 
`AdminClient.close` is called in callback thread
URL: https://github.com/apache/kafka/pull/7866
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Calling AdminClient.close in the AdminClient completion callback causes 
> deadlock
> --------------------------------------------------------------------------------
>
>                 Key: KAFKA-9330
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9330
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Vikas Singh
>            Assignee: Vikas Singh
>            Priority: Major
>
> The close method calls `Thread.join` to wait for AdminClient thread to die, 
> but that doesn't happen as the thread calling join is the AdminClient thread. 
> This causes the thread to block forever, causing a deadlock where it forever 
> waits for itself to die. 
> `AdminClient.close` should check if the thread calling close is same as 
> current thread, then skip the join. The thread will check for close condition 
> in the main loop and exit.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to