[
https://issues.apache.org/jira/browse/KAFKA-9246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17002174#comment-17002174
]
ASF GitHub Bot commented on KAFKA-9246:
---------------------------------------
dengziming commented on pull request #7862: KAFKA-9246:Update Heartbeat timeout
when ConsumerCoordinator commit offset
URL: https://github.com/apache/kafka/pull/7862
I misoperated my git and need to reopen a PR(the original one is #7761).
notice this can only be merged after #7312 is merged.
1. bump the protocol version of `CommitOffsetReq` and add a parameter to
`GroupCoordinator.doCommitOffsets` to identify whether should we respond
`REBALANCE_IN_PROGRESS`;
2. when in `PreparingRebalance`, `GroupCoordinator` no longer respond a
success but a `REBALANCE_IN_PROGRESS` error even if commit succeed;
3. client will interpret it intelligently if #7312 is merged
and the interaction is as follows:
1. if an OLD client commits offset, it just acts as previous, and the broker
will also act as previous;
2. if a new client commits offset, it will update heartbeat, the broker may
respond a `REBALANCE_IN_PROGRESS`, the client also has the logic to handle it.
the one disadvantage is that when in `PreparingRebalance` we used to
response a success but now an error.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update Heartbeat timeout when ConsumerCoordinator commit offset
> ---------------------------------------------------------------
>
> Key: KAFKA-9246
> URL: https://issues.apache.org/jira/browse/KAFKA-9246
> Project: Kafka
> Issue Type: Improvement
> Components: clients
> Reporter: dengziming
> Assignee: dengziming
> Priority: Minor
> Fix For: 2.2.0, 2.3.0
>
>
> when a consumer sends OffsetCommitRequest, it also can be treated as a
> Heartbeat and the `GroupCoordinator` will invoke
> `completeAndScheduleNextHeartbeatExpiration` to update the expires when
> handleCommitOffsets.
> so we can also update the heartbeat expires of ConsumerCoordinator when send
> OffsetCommitRequest to reduce Heartbeat Request.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
