[
https://issues.apache.org/jira/browse/KAFKA-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16999856#comment-16999856
]
Jono Morris edited comment on KAFKA-9049 at 12/19/19 9:06 AM:
--------------------------------------------------------------
A number of the tests seem to depend on KafkaServerTestHarness, and rely on
having those brokers set up. What would be the best practice here. These test
cases could be moved to a new Test class?
was (Author: jono.mor...@xtra.co.nz):
A number of the tests rely on having those brokers set up. What would be the
best practice here. These test cases could be moved to a new Test class?
> TopicCommandWithAdminClientTest should use mocks
> ------------------------------------------------
>
> Key: KAFKA-9049
> URL: https://issues.apache.org/jira/browse/KAFKA-9049
> Project: Kafka
> Issue Type: Improvement
> Components: unit tests
> Affects Versions: 2.5.0
> Reporter: Viktor Somogyi-Vass
> Assignee: Dhiraj Dwarapudi
> Priority: Minor
> Labels: easy, newbie, newbie++
>
> The {{TopicCommandWithAdminClientTest}} class currently sets up a few brokers
> for every test case which is wasteful and slow. We should improve it by
> mocking out the broker behavior (maybe use {{MockAdminClient}}?).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
