[
https://issues.apache.org/jira/browse/KAFKA-8953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16991102#comment-16991102
]
ASF GitHub Bot commented on KAFKA-8953:
---------------------------------------
mjsax commented on pull request #7633: KAFKA-8953: Rename
UsePreviousTimeOnInvalidTimestamp to UsePartitionTimeOnInvalidTimestamp
URL: https://github.com/apache/kafka/pull/7633
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Consider renaming `UsePreviousTimeOnInvalidTimestamp` timestamp extractor
> -------------------------------------------------------------------------
>
> Key: KAFKA-8953
> URL: https://issues.apache.org/jira/browse/KAFKA-8953
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Reporter: Matthias J. Sax
> Assignee: Rabi Kumar K C
> Priority: Trivial
> Labels: beginner, kip, newbie
>
> Kafka Streams ships couple of different timestamp extractors, one named
> `UsePreviousTimeOnInvalidTimestamp`.
> Given the latest improvements with regard to time tracking, it seems
> appropriate to rename this class to `UsePartitionTimeOnInvalidTimestamp`, as
> we know have fixed definition of partition time, and also pass in partition
> time into the `#extract(...)` method, instead of some non-well-defined
> "previous timestamp".
> KIP-530:
> [https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=130028807]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
