[ 
https://issues.apache.org/jira/browse/KAFKA-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16990681#comment-16990681
 ] 

John Roesler commented on KAFKA-9234:
-------------------------------------

Hi [~hmed06],

The answer is yes, you can just assign any unassigned ticket to yourself if you 
want to work on it. Although, it looks like [~manasvigupta] has just also 
claimed it (sorry, I didn't notice this ticket until just now).

However, this task as written is gigantic (it's for the entire public API), and 
[~mjsax] mentioned that it needs to be broken down. Maybe you can just pick 
your favorite class in the Public API and make a subtask for yourself to add 
the annotations to it?

Likewise, just a thought for [~manasvigupta] as well, it seems like the first 
order of business is to enumerate all the API classes that need annotations 
added and create a subtask for each... But this is just my free advice ;) 

Thanks to you both for volunteering to help!
-John

> Consider using @Nullable and @Nonnull annotations
> -------------------------------------------------
>
>                 Key: KAFKA-9234
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9234
>             Project: Kafka
>          Issue Type: Improvement
>          Components: admin, clients, consumer, KafkaConnect, producer , 
> streams, streams-test-utils
>            Reporter: Matthias J. Sax
>            Assignee: Manasvi Gupta
>            Priority: Minor
>              Labels: beginner, newbie
>
> Java7 was dropped some time ago, and we might want to consider usein Java8 
> `@Nullable` and `@Nonnull` annotations for all public facing APIsĀ instead of 
> documenting it in JavaDocs only.
> This tickets should be broken down in a series of smaller PRs to keep the 
> scope of each PR contained, allowing for more effective reviews.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to