[
https://issues.apache.org/jira/browse/KAFKA-9202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979800#comment-16979800
]
ASF GitHub Bot commented on KAFKA-9202:
---------------------------------------
huxihx commented on pull request #7736: KAFKA-9202: serde in ConsoleConsumer
with access to headers
URL: https://github.com/apache/kafka/pull/7736
https://issues.apache.org/jira/browse/KAFKA-9202
The Deserializer interface has two methods, one that gives access to the
headers and one that does not. ConsoleConsumer.scala only calls the latter
method. It would be nice if it were to call the default method that provides
header access, so that custom serde that depends on headers becomes possible.
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> serde in ConsoleConsumer with access to headers
> -----------------------------------------------
>
> Key: KAFKA-9202
> URL: https://issues.apache.org/jira/browse/KAFKA-9202
> Project: Kafka
> Issue Type: Improvement
> Components: consumer
> Affects Versions: 2.3.0
> Reporter: Jorg Heymans
> Assignee: huxihx
> Priority: Major
>
> ML thread here :
> [https://lists.apache.org/thread.html/ab8c3094945cb9f9312fd3614a5b4454f24756cfa1a702ef5c739c8f@%3Cusers.kafka.apache.org%3E]
>
> The Deserializer interface has two methods, one that gives access to the
> headers and one that does not. ConsoleConsumer.scala only calls the latter
> method. It would be nice if it were to call the default method that provides
> header access, so that custom serde that depends on headers becomes possible.
> Currently it does this:
>
> {code:java}
> deserializer.map(_.deserialize(topic, nonNullBytes).toString.
> getBytes(StandardCharsets.UTF_8)).getOrElse(nonNullBytes)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
