[
https://issues.apache.org/jira/browse/KAFKA-8945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16938142#comment-16938142
]
ASF GitHub Bot commented on KAFKA-8945:
---------------------------------------
C0urante commented on pull request #7392: KAFKA-8945: Fix bug in Connect REST
extension API caused by invalid constructor parameter validation
URL: https://github.com/apache/kafka/pull/7392
[Jira](https://issues.apache.org/jira/browse/KAFKA-8945)
The changes here are simple: a few checks to ensure that constructor
parameters in the `AbstractState` and `ConnectorHealth` classes are non-null
and non-empty are fixed. The current logic erroneously ensures that they are
either null or empty.
The `RestExtensionIntegrationTest` is expanded on to test these changes in
the wild, verifying that they work and preventing any future regressions.
This fix should be backported through to 2.0, when Connect REST extensions
were initially introduced.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Incorrect null check in the constructor for ConnectorHealth and AbstractState
> -----------------------------------------------------------------------------
>
> Key: KAFKA-8945
> URL: https://issues.apache.org/jira/browse/KAFKA-8945
> Project: Kafka
> Issue Type: Bug
> Components: KafkaConnect
> Affects Versions: 2.3.0
> Reporter: Sanjana Kaundinya
> Assignee: Chris Egerton
> Priority: Major
> Labels: kafka-connect, rest_api
>
> This bug is in relation to KIP-285:
> [https://cwiki.apache.org/confluence/display/KAFKA/KIP-285%3A+Connect+Rest+Extension+Plugin]
> In the constructors of ConnectorHealth.java and AbstractState.java, the check
> that is done for the null parameters is done incorrectly. The current code
> only allows for the class to be instantiated if the parameters passed in are
> null. However the expected behavior has to be the opposite of this: we only
> want this class to be instantiated if the parameters passed in are not null.
> While the fix for this is pretty trivial, it would be good to add in some
> testing that tests the appropriate classes related to the rest extension.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
