[ 
https://issues.apache.org/jira/browse/KAFKA-8473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854910#comment-16854910
 ] 

ASF GitHub Bot commented on KAFKA-8473:
---------------------------------------

kkonstantine commented on pull request #6872: KAFKA-8473: Adjust Connect system 
tests for incremental cooperative rebalancing
URL: https://github.com/apache/kafka/pull/6872
 
 
   As predicted by the new incremental cooperative rebalancing protocol, when a 
worker leaves the group a delay is triggered, controlled by the 
scheduled.rebalance.max.delay.ms property, during which the tasks detected as 
lost due to the workers departure are not reassigned. After this delay, workers 
are joining for another rebalancing round to reschedule the lost tasks. 
   
   System tests that perform worker bounces need to account for this delay. 
   This PR is also enabled connect system tests on distributed workers for both 
eager and incremental cooperative rebalancing protocols. 
   
   Tested by repeated runs of system tests. 
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Adjust Connect system tests for incremental cooperative rebalancing and 
> enable them for both eager and incremental cooperative rebalancing
> ------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-8473
>                 URL: https://issues.apache.org/jira/browse/KAFKA-8473
>             Project: Kafka
>          Issue Type: Bug
>          Components: KafkaConnect
>    Affects Versions: 2.3
>            Reporter: Konstantine Karantasis
>            Assignee: Konstantine Karantasis
>            Priority: Critical
>             Fix For: 2.3
>
>
>  
> {{connect.protocol=compatible}} that enables incremental cooperative 
> rebalancing if all workers are in that version is now the default option. 
> System tests should be parameterized to keep running the for eager 
> rebalancing protocol as well to make sure no regression have happened. 
> Also, for the incremental cooperative protocol, a few tests need to be 
> adjusted to have a lower rebalancing delay (the delay that is applied to wait 
> for returning workers) 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to