[
https://issues.apache.org/jira/browse/KAFKA-6029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848809#comment-16848809
]
Jiangjie Qin commented on KAFKA-6029:
-------------------------------------
[~hachikuji] Yes, I think the issue should have been resolved. There are
actually two scenarios mentioned in this ticket.
The original one is more of an issue that the controller messages are processed
at different time in different brokers. This should have been addressed by
[KIP-291|[https://cwiki.apache.org/confluence/display/KAFKA/KIP-291%3A+Separating+controller+connections+and+requests+from+the+data+plane]].
Another issue was that shutting down brokers are incorrectly added back to ISR
by the leader, which is addressed by
[KIP-320|[https://cwiki.apache.org/confluence/display/KAFKA/KIP-320%3A+Allow+fetchers+to+detect+and+handle+log+truncation]]
as you mentioned.
> Controller should wait for the leader migration to finish before ack a
> ControlledShutdownRequest
> ------------------------------------------------------------------------------------------------
>
> Key: KAFKA-6029
> URL: https://issues.apache.org/jira/browse/KAFKA-6029
> Project: Kafka
> Issue Type: Sub-task
> Components: controller, core
> Affects Versions: 1.0.0
> Reporter: Jiangjie Qin
> Assignee: Zhanxiang (Patrick) Huang
> Priority: Major
>
> In the controlled shutdown process, the controller will return the
> ControlledShutdownResponse immediately after the state machine is updated.
> Because the LeaderAndIsrRequests and UpdateMetadataRequests may not have been
> successfully processed by the brokers, the leader migration and active ISR
> shrink may not have done when the shutting down broker proceeds to shut down.
> This will cause some of the leaders to take up to replica.lag.time.max.ms to
> kick the broker out of ISR. Meanwhile the produce purgatory size will grow.
> Ideally, the controller should wait until all the LeaderAndIsrRequests and
> UpdateMetadataRequests has been acked before sending back the
> ControlledShutdownResponse.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
