[
https://issues.apache.org/jira/browse/KAFKA-8305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839617#comment-16839617
]
ASF GitHub Bot commented on KAFKA-8305:
---------------------------------------
agavra commented on pull request #6728: KAFKA-8305: support default partitions
& replication factor in AdminClient#createTopic
URL: https://github.com/apache/kafka/pull/6728
See:
[KIP-464](https://cwiki.apache.org/confluence/display/KAFKA/KIP-464%3A+Defaults+for+AdminClient%23createTopic)
for more information.
### Description
This change makes the two required changes to support creating topics using
the cluster defaults for replication and partitions:
1. Adds a `NewTopic(String)` constructor to the `NewTopic` API
2. Changes the `AdminManager` to accept `-1` as valid options for
replication factor and partitions. If this is the case, it will resolve it
using the default configuration.
### Testing
- Updated unit tests with the new conditions
- **TODO:** I still need to do end-to-end testing by spinning up my own
Kafka cluster using this code and making sure that it works, but I'm putting
the PR out early for review since the feature freeze is coming up soon
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> AdminClient should support creating topics with default partitions and
> replication factor
> -----------------------------------------------------------------------------------------
>
> Key: KAFKA-8305
> URL: https://issues.apache.org/jira/browse/KAFKA-8305
> Project: Kafka
> Issue Type: Improvement
> Components: admin
> Reporter: Almog Gavra
> Priority: Major
>
> Today, the AdminClient creates topics by requiring a `NewTopic` object, which
> must contain either partitions and replicas or an exact broker mapping (which
> then infers partitions and replicas). Some users, however, could benefit from
> just using the cluster default for replication factor but may not want to use
> auto topic creation.
> NOTE: I am planning on working on this, but I do not have permissions to
> assign this ticket to myself.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
