[
https://issues.apache.org/jira/browse/KAFKA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18097723#comment-18097723
]
Preethi KCS commented on KAFKA-14922:
-------------------------------------
Hi [~alisa23]
Following up on my blocker above regarding
{{{}shouldDefaultToClassicGroupProtocol{}}},
{{{}shouldAllowGroupProtocolClassic{}}}, and
{{{}shouldOverwriteGroupProtocolOtherThanClassic{}}}.
To answer my own question — rather than updating these tests to create a real
consumer group (which would be heavier and not actually relevant to what
they're testing), I added {{--force}} to their parameters instead.
These three tests exist to verify the {{GROUP_PROTOCOL_CONFIG}}
override/defaulting-to-CLASSIC behavior, not the new application-id existence
check. They use a synthetic {{application.id}} via {{safeUniqueTestName}}
that's never registered as a real consumer group, so with
{{validateApplicationIdExists}} now running at the start of {{{}execute(){}}},
they were failing fast with {{IllegalArgumentException}} before ever reaching
the CLASSIC override logic.
Adding {{--force}} just skips the existence check for these tests, so they can
get straight to testing the group-protocol logic they're actually meant to
test, without mixing that up with the app-id validation check. This also lines
up with how we agreed {{--force}} should work earlier: it's meant to force the
whole reset through, not just skip removing members.
All three now pass locally. Updated code is pushed to the PR.
I think {{--force}} is the cleaner fix here.
> kafka-streams-application-reset deletes topics not belonging to specified
> application-id
> ----------------------------------------------------------------------------------------
>
> Key: KAFKA-14922
> URL: https://issues.apache.org/jira/browse/KAFKA-14922
> Project: Kafka
> Issue Type: Bug
> Components: streams, tools
> Affects Versions: 3.4.0
> Reporter: Jørgen
> Assignee: Preethi KCS
> Priority: Major
> Labels: beginner, needs-kip, newbie
>
> Slack-thread:
> [https://confluentcommunity.slack.com/archives/C48AHTCUQ/p1681908267206849]
> When running the command _kafka-streams-application-reset --bootstrap-servers
> $BOOTSTRAP --application-id foo_ all internal topics that _starts with_ foo
> is deleted. This happens even if there's no application-id named foo.
> Example:
> {code:java}
> Application IDs:
> foo-v1
> foo-v2
> Internal topics:
> foo-v1-repartition-topic-repartition
> foo-v2-repartition-topic-repartition
> Application reset:
> kafka-streams-application-reset --bootstrap-servers $BOOTSTRAP
> --application-id foo
> > No input or intermediate topics specified. Skipping seek.
> Deleting inferred internal topics [foo-v2-repartition-topic-repartition,
> foo-v1-repartition-topic-repartition]
> Done.{code}
> Expected behaviour is that the command fails as there are no application-id's
> with the name foo instead of deleting all foo* topics.
> This is critical on typos or if application-ids starts with the same name as
> others (for example if we had foo-v21 and wanted to reset foo-v2)
> The bug should be located here:
> [https://github.com/apache/kafka/blob/c14f56b48461f01743146d58987bc8661ba0d459/tools/src/main/java/org/apache/kafka/tools/StreamsResetter.java#L693]
> Should check that the topics matches the application-id exactly instead of
> checking that it starts with the application-id.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
