ezhou413 commented on code in PR #22667:
URL: https://github.com/apache/kafka/pull/22667#discussion_r3618005372
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManagerTest.java:
##########
@@ -469,6 +471,52 @@ public void
testRequestPartiallyFailsWithRetriableError_RetrySucceeds() throws E
verifyRequestSuccessfullyCompleted(fetchOffsetsFuture,
expectedOffsets);
}
+ @Test
+ public void testListOffsetsRetriedToNewLeaderAfterMetadataUpdate() throws
ExecutionException,
Review Comment:
Looking at
`OffsetFetcherTest.testGetOffsetByTimeWithPartitionsRetryCouldTriggerMetadataUpdate()`,
we test the metadata refresh behavior on a list of retriable errors. Should we
do that here as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
