chia7712 commented on code in PR #20376:
URL: https://github.com/apache/kafka/pull/20376#discussion_r3609273990
##########
test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/ClusterInstance.java:
##########
@@ -150,7 +150,7 @@ default <K, V> Producer<K, V> producer(Map<String, Object>
configs) {
props.putIfAbsent(ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG,
ByteArraySerializer.class.getName());
props.putIfAbsent(ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG,
ByteArraySerializer.class.getName());
props.putIfAbsent(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG,
bootstrapServers());
- return new KafkaProducer<>(setClientSaslConfig(props));
+ return new
KafkaProducer<>(setClientSaslConfig(setClientSslConfig(props)));
Review Comment:
We should have a `createClientSecurityConfig` method to unify
`setClientSaslConfig` and `setClientSslConfig`. The call chain is a bit
counterintuitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
