m1a2st commented on code in PR #22854:
URL: https://github.com/apache/kafka/pull/22854#discussion_r3601555524
##########
storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerTest.java:
##########
@@ -216,7 +216,7 @@ public class RemoteLogManagerTest {
private UnifiedLog mockLog = mock(UnifiedLog.class);
private final MockScheduler scheduler = new MockScheduler(time);
- private final Properties brokerConfig =
kafka.utils.TestUtils.createDummyBrokerConfig();
+ private final Properties brokerConfig = new Properties();
Review Comment:
Empty properties are not a broker config, so the naming should be updated as
well.
##########
storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLagCopyTest.java:
##########
@@ -85,7 +85,7 @@ public class RemoteLagCopyTest {
private final UnifiedLog mockLog = mock(UnifiedLog.class);
private final Metrics metrics = new Metrics(time);
- private final Properties brokerConfig =
kafka.utils.TestUtils.createDummyBrokerConfig();
+ private final Properties brokerConfig = new Properties();
Review Comment:
We can inline this variable. Also, empty properties are not a broker config,
so the naming should be updated as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
