unknowntpo commented on code in PR #22588:
URL: https://github.com/apache/kafka/pull/22588#discussion_r3548665017
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SampleSourceConnector.java:
##########
@@ -67,6 +69,16 @@ public ConfigDef configWithCommon() {
.define("optional", ConfigDef.Type.STRING, "defaultVal",
ConfigDef.Importance.HIGH, "optional docs");
}
+ @Override
+ public Config validate(Map<String, String> connectorConfigs) {
Review Comment:
`SampleSourceConnector` is a shared fixture (also used by `WorkerTest`,
`ConnectorPluginsResourceTest`, and `TestableSourceConnector` which extends
it), so overriding its `validate()` changes its behavior and might affects
those other tests too. Would a small dedicated connector scoped to this test be
cleaner ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
