nicktelford commented on code in PR #22683:
URL: https://github.com/apache/kafka/pull/22683#discussion_r3490296113
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##########
@@ -1479,7 +1523,21 @@ public Options getOptions() {
@Override
public Position getPosition() {
- return position;
+ synchronized (position) {
+ return
position.copy().merge(dbAccessor.uncommittedPositionDeltas());
+ }
+ }
+
+ // Visible for testing. Returns a snapshot of the committed Position only
(no pending writes).
+ Position committedPositionForTest() {
Review Comment:
No methods, but we can make the `position` field package-private and
directly access it. `dbAccessor` is already package-private, so we can
eliminate that method for free.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
