jiafu1115 commented on PR #22394: URL: https://github.com/apache/kafka/pull/22394#issuecomment-4828079571
<img width="1495" height="797" alt="image" src="https://github.com/user-attachments/assets/8ca9ccaf-cb67-4649-a8b3-f696b4f027b1"; /> Thanks for the discussion. refer to code and test metric in the KIP for this case. it won't change the existed behavior when user don't change any configure due to the default lag ms is 0. the change for the default size is for user only need to change one configure instead of two configures for most of the cases (only set time as retention. also it is default configure for kafka.) if (copyLagMs == 0 || copyLagBytes == 0) { return true; } cc @kamalcph @showuon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
